Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DataView, remove dependency on ieee754 #365

Open
james-pre opened this issue Nov 25, 2024 · 3 comments
Open

Use DataView, remove dependency on ieee754 #365

james-pre opened this issue Nov 25, 2024 · 3 comments
Assignees

Comments

@james-pre
Copy link

DataViews would simplify a huge amount of the read* and write* methods. Additionally, using DataView would eliminate the need for the ieee754 dependency. This would save users time and storage when installing buffer. Additionally, ieee754 has not received any updates in the past 4 years.

@james-pre
Copy link
Author

james-pre commented Jan 6, 2025

Pinging @feross @dcousens

@yume-chan
Copy link

yume-chan commented Jan 8, 2025

Creating DataViews costs CPU cycles and memory. If a user is dealing with many small Buffers, creating DataView for each of them will reduce the performance by more than 50%: https://github.com/yume-chan/ya-webadb/blob/main/libraries/no-data-view/benchmark.md

@james-pre
Copy link
Author

I heard about the performance hit somewhere else. Maybe only for reading and writing floats? I think that may be where the performance can be improved.

@dcousens dcousens self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants