From ea486168339b8288dc0cee062caa25a1cc8bdf3d Mon Sep 17 00:00:00 2001
From: Andrew Jiang <andrew@buildwithfern.com>
Date: Thu, 9 May 2024 19:07:58 -0400
Subject: [PATCH] fix: support nested FlattenApiSection (#840)

---
 .../ui/app/src/sidebar/SidebarApiSection.tsx  | 75 +++++++++++--------
 1 file changed, 44 insertions(+), 31 deletions(-)

diff --git a/packages/ui/app/src/sidebar/SidebarApiSection.tsx b/packages/ui/app/src/sidebar/SidebarApiSection.tsx
index 67ce20a311..12844cf55e 100644
--- a/packages/ui/app/src/sidebar/SidebarApiSection.tsx
+++ b/packages/ui/app/src/sidebar/SidebarApiSection.tsx
@@ -28,39 +28,21 @@ export const SidebarApiSection: React.FC<SidebarApiSectionProps> = ({
 }) => {
     const { selectedSlug } = useCollapseSidebar();
 
+    if (apiSection.isSidebarFlattened) {
+        return (
+            <li>
+                <FlattenedApiSection
+                    apiSection={apiSection}
+                    registerScrolledToPathListener={registerScrolledToPathListener}
+                    depth={depth}
+                />
+            </li>
+        );
+    }
+
     return depth === 0 ? (
         <li>
-            {apiSection.isSidebarFlattened ? (
-                <ul className="fern-sidebar-group">
-                    {apiSection.items.map((item) =>
-                        visitDiscriminatedUnion(item, "type")._visit({
-                            apiSection: (item) => (
-                                <SidebarApiSection
-                                    key={item.id}
-                                    apiSection={item}
-                                    registerScrolledToPathListener={registerScrolledToPathListener}
-                                    depth={depth}
-                                />
-                            ),
-                            page: (item) => (
-                                <SidebarApiSlugLink
-                                    key={joinUrlSlugs(...item.slug)}
-                                    item={item}
-                                    api={apiSection.api}
-                                    registerScrolledToPathListener={registerScrolledToPathListener}
-                                    depth={depth}
-                                />
-                            ),
-                            _other: () => (
-                                <FernErrorTag
-                                    component="SidebarApiSection"
-                                    error="Tried to render unknown api section."
-                                />
-                            ),
-                        }),
-                    )}
-                </ul>
-            ) : apiSection.summaryPage != null ? (
+            {apiSection.summaryPage != null ? (
                 <SidebarSlugLink
                     className={cn({
                         "mt-6": depth === 0,
@@ -306,3 +288,34 @@ export const ExpandableSidebarApiSection: React.FC<ExpandableSidebarApiSectionPr
         </SidebarSlugLink>
     );
 };
+
+function FlattenedApiSection({ apiSection, registerScrolledToPathListener, depth }: SidebarApiSectionProps) {
+    return (
+        <ul className="fern-sidebar-group">
+            {apiSection.items.map((item) =>
+                visitDiscriminatedUnion(item, "type")._visit({
+                    apiSection: (item) => (
+                        <SidebarApiSection
+                            key={item.id}
+                            apiSection={item}
+                            registerScrolledToPathListener={registerScrolledToPathListener}
+                            depth={depth}
+                        />
+                    ),
+                    page: (item) => (
+                        <SidebarApiSlugLink
+                            key={joinUrlSlugs(...item.slug)}
+                            item={item}
+                            api={apiSection.api}
+                            registerScrolledToPathListener={registerScrolledToPathListener}
+                            depth={depth}
+                        />
+                    ),
+                    _other: () => (
+                        <FernErrorTag component="SidebarApiSection" error="Tried to render unknown api section." />
+                    ),
+                }),
+            )}
+        </ul>
+    );
+}