From 2b01e74ec740912ea6625e07093f9c96d2dec77f Mon Sep 17 00:00:00 2001 From: Bhaskar Singhvi <31942378+bsinghvi@users.noreply.github.com> Date: Wed, 1 May 2024 18:41:56 -0400 Subject: [PATCH 1/2] Updating ALB alarm for 5xx to ALB itself (#720) Co-authored-by: Deep Singhvi --- servers/fdr-deploy/scripts/fdr-deploy-stack.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/servers/fdr-deploy/scripts/fdr-deploy-stack.ts b/servers/fdr-deploy/scripts/fdr-deploy-stack.ts index 29683c6843..af809e79b3 100644 --- a/servers/fdr-deploy/scripts/fdr-deploy-stack.ts +++ b/servers/fdr-deploy/scripts/fdr-deploy-stack.ts @@ -6,7 +6,7 @@ import * as actions from "aws-cdk-lib/aws-cloudwatch-actions"; import { Peer, Port, SecurityGroup, Vpc } from "aws-cdk-lib/aws-ec2"; import { Cluster, ContainerImage, LogDriver, Volume } from "aws-cdk-lib/aws-ecs"; import { ApplicationLoadBalancedFargateService } from "aws-cdk-lib/aws-ecs-patterns"; -import { ApplicationProtocol, HttpCodeTarget } from "aws-cdk-lib/aws-elasticloadbalancingv2"; +import { ApplicationProtocol, HttpCodeElb } from "aws-cdk-lib/aws-elasticloadbalancingv2"; import { LogGroup } from "aws-cdk-lib/aws-logs"; import { ARecord, HostedZone, RecordTarget } from "aws-cdk-lib/aws-route53"; import { LoadBalancerTarget } from "aws-cdk-lib/aws-route53-targets"; @@ -192,7 +192,7 @@ export class FdrDeployStack extends Stack { const lb500CountAlarm = new Alarm(this, "fdr-lb-5XX-count", { alarmName: `${id} Load Balancer 500 Error Alarm`, - metric: fargateService.loadBalancer.metrics.httpCodeTarget(HttpCodeTarget.TARGET_5XX_COUNT), + metric: fargateService.loadBalancer.metrics.httpCodeElb(HttpCodeElb.ELB_5XX_COUNT), threshold: 2, evaluationPeriods: 5, }); From a07443e725a5ef45c4ac5a551e392903b1ca6a8b Mon Sep 17 00:00:00 2001 From: Deep Singhvi Date: Wed, 1 May 2024 19:01:09 -0400 Subject: [PATCH 2/2] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f10841a2e5..8d63b9237a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ -Fixes ENG- +Fixes FER- ## Short description of the changes made