From cc2f8d6945c2d5402109fbfb6ff35b0c8c86deb0 Mon Sep 17 00:00:00 2001 From: Andrew Jiang Date: Sat, 14 Sep 2024 19:22:38 -0400 Subject: [PATCH] conditions are broken --- .github/actions/vercel/action.yml | 3 --- .github/workflows/deploy-docs-bundle-preview.yml | 5 ++--- .github/workflows/deploy-docs-bundle-prod.yml | 6 +----- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/.github/actions/vercel/action.yml b/.github/actions/vercel/action.yml index 46031d1bcf..4001becab2 100644 --- a/.github/actions/vercel/action.yml +++ b/.github/actions/vercel/action.yml @@ -29,9 +29,6 @@ outputs: deployment_url: description: The URL of the deployment value: ${{ steps.deploy-preview.outputs.deployment_url || steps.deploy-production.outputs.deployment_url }} - exit_code: - description: Skip the deployment - value: ${{ steps.ignore-build.outputs.exit_code || inputs.force == 'true' }} runs: using: "composite" diff --git a/.github/workflows/deploy-docs-bundle-preview.yml b/.github/workflows/deploy-docs-bundle-preview.yml index 83ff403664..a57812b93f 100644 --- a/.github/workflows/deploy-docs-bundle-preview.yml +++ b/.github/workflows/deploy-docs-bundle-preview.yml @@ -23,7 +23,6 @@ jobs: url: ${{ steps.deploy.outputs.deployment_url }} outputs: deployment_url: ${{ steps.deploy.outputs.deployment_url }} - exit_code: ${{ steps.deploy.outputs.exit_code }} steps: - uses: actions/checkout@v4 with: @@ -43,7 +42,7 @@ jobs: deploy-dev: needs: deploy # this will run after the deploy job to leverage turbo's build cache - if: needs.deploy.outputs.exit_code + if: needs.deploy.outputs.deployment_url runs-on: ubuntu-latest environment: name: Preview - app-dev.buildwithfern.com @@ -97,7 +96,7 @@ jobs: ete: needs: deploy - if: needs.deploy.outputs.exit_code + if: needs.deploy.outputs.deployment_url runs-on: ubuntu-latest permissions: write-all steps: diff --git a/.github/workflows/deploy-docs-bundle-prod.yml b/.github/workflows/deploy-docs-bundle-prod.yml index 6338eaf7c5..e6626cf6a7 100644 --- a/.github/workflows/deploy-docs-bundle-prod.yml +++ b/.github/workflows/deploy-docs-bundle-prod.yml @@ -22,7 +22,6 @@ jobs: url: ${{ steps.deploy.outputs.deployment_url }} outputs: deployment_url: ${{ steps.deploy.outputs.deployment_url }} - exit_code: ${{ steps.deploy.outputs.exit_code }} env: VERCEL_PROJECT_ID: prj_QX3venU6jwRUmdt8ArfL8AU5r1d4 steps: @@ -46,7 +45,6 @@ jobs: url: ${{ steps.deploy.outputs.deployment_url }} outputs: deployment_url: ${{ steps.deploy.outputs.deployment_url }} - exit_code: ${{ steps.deploy.outputs.exit_code }} env: VERCEL_PROJECT_ID: prj_SfgTTzw7KefTMuVWsL5uhY8Y4BIt steps: @@ -70,7 +68,6 @@ jobs: url: ${{ steps.deploy.outputs.deployment_url }} outputs: deployment_url: ${{ steps.deploy.outputs.deployment_url }} - exit_code: ${{ steps.deploy.outputs.exit_code }} env: VERCEL_PROJECT_ID: prj_GGc6CEzrWNyUK0hq1UK7KmbgUmZn steps: @@ -88,7 +85,7 @@ jobs: ete: needs: deploy_app_buildwithfern_com - if: needs.deploy_app_buildwithfern_com.outputs.exit_code + if: needs.deploy_app_buildwithfern_com.outputs.deployment_url runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -116,7 +113,6 @@ jobs: - ${{ needs.deploy_app_buildwithfern_com.outputs.deployment_url }} - ${{ needs.deploy_app_ferndocs_com.outputs.deployment_url }} - ${{ needs.deploy_app-slash_ferndocs_com.outputs.deployment_url }} - if: needs.deploy_app_buildwithfern_com.outputs.exit_code && needs.deploy_app_ferndocs_com.outputs.exit_code && needs.deploy_app-slash_ferndocs_com.outputs.exit_code steps: - uses: actions/checkout@v4