Missing weights when averaging

[omarfoq]

Hello,

I am not sure if this an error, but it seems you are not weighting the clients when averaging reduce_add_average. Moreover, in the paper you use Local SGD with same number of steps at each client, while in the code you fit a fixed number of epochs, thus the number of steps is not constant across clients, and depends on the local data size.

I am not sure if what I highlight here is relevant, can you please clarify this if possible.