Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of breaking changes #2388

Closed
valle-xyz opened this issue Apr 14, 2021 · 3 comments
Closed

A lot of breaking changes #2388

valle-xyz opened this issue Apr 14, 2021 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@valle-xyz
Copy link

Hey @felangel, 👋🏻

I really like this library and I am really impressed by your coding skills and by the effort you put into this. This is without doubt one of the most important libraries in the flutter space.

I realized, that I spend most of the time I have to put into the maintenance of my app with the breaking changes of the bloc library and its siblings (last one mocktail). So this library not only helps me most but also needs the most time.

There is no request or proposal, but I just wanted to raise this and hear your thoughts on it.

Thanks again for your great work! 🙏🏻

@felangel felangel self-assigned this Apr 15, 2021
@felangel felangel added question Further information is requested waiting for response Waiting for follow up labels Apr 15, 2021
@felangel
Copy link
Owner

Hi @Valentin-Seehausen 👋
Thanks for opening an issue!

It would be really helpful if you could provide more information regarding which breaking changes you spent the most time on.

Unfortunately, switching to mocktail was done out of necessity due to null safety support (see dart-lang/mockito#286 and dart-lang/mockito#347). Without mocktail it would not have been possible to support the existing blocTest api when it came to mocking and there would have likely been much larger breaking changes involving code generation.

I have tried my best to provide migration guides to walk through all breaking changes and explain why they were made and how to upgrade. I hope that helps and I apologize for any inconvenience!

@valle-xyz
Copy link
Author

valle-xyz commented Apr 16, 2021

Hey @felangel,

thank you very much for your kind answer.

I don't think there are breaking changes that need more work than others but in sum, it's just a lot. Nothing more. The migration guides are very good. 🙏🏻

The update to null-safety was obviously a huge step all libraries needed to go. Still, I am stuck with some failing tests and weird errors due to mocktail where I have to spend time to maintenance and can't develop new features.

@felangel
Copy link
Owner

felangel commented Apr 19, 2021

@Valentin-Seehausen I'm sorry to hear that and I understand how you feel -- migrating large applications to null safety is fairly challenging. If you haven't already, I highly recommend joining the bloc discord and you can post any questions/challenges you have when migrating (failing tests, weird errors, etc.) and I'm sure the community will be able to help 👍

Closing for now since there don't appear to be any actionable items, thanks! 🙏

@felangel felangel removed the waiting for response Waiting for follow up label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants