Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate OAuth Authorization Grants from Access Tokens #125

Open
ThisIsMissEm opened this issue Feb 23, 2025 · 2 comments
Open

Separate OAuth Authorization Grants from Access Tokens #125

ThisIsMissEm opened this issue Feb 23, 2025 · 2 comments

Comments

@ThisIsMissEm
Copy link
Contributor

Currently our database contains just an access_tokens table, which stores authorization grants that haven't yet been approved (i.e., aren't yet valid access tokens)

In order to implement security features in OAuth such as PKCE, we'd need to store additional information with the authorization grant. Likewise, we'd need to adjust the access tokens model in order to support Refresh Grants (allowing shorter-lived access tokens)

Additionally in the OAuth flow, only specific grant types can pass certain parameters to the oauth token endpoint, e.g., scope isn't valid for an authorization code grant.

Separating these tables would make our oauth implementation more understandable.

@ThisIsMissEm
Copy link
Contributor Author

I expect that resolving this issue would likely mean that all access tokens / access grants would need to be invalidated, requiring people using hollo to reauthenticate / login again.

@dahlia
Copy link
Member

dahlia commented Feb 24, 2025

I expect that resolving this issue would likely mean that all access tokens / access grants would need to be invalidated, requiring people using hollo to reauthenticate / login again.

I think it's not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants