Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make empty string behavior consistent on the legal search endpoint #6024

Open
1 task
cnlucas opened this issue Oct 18, 2024 · 0 comments · May be fixed by #6088
Open
1 task

Make empty string behavior consistent on the legal search endpoint #6024

cnlucas opened this issue Oct 18, 2024 · 0 comments · May be fixed by #6088

Comments

@cnlucas
Copy link
Member

cnlucas commented Oct 18, 2024

What we’re after

We recently resolved a bug that caused certain filters in Swagger to return zero results when -- was selected. Now, selecting -- correctly returns all results for newer filters. While this fix has been applied to some filters, it should be consistently implemented across all filters.

We should also include this fix in the validation of the args as well.

It was first changed in the disposition ticket but was also updated in the subject ticket later. There's some differences between these two solutions, but the same outcome. (Adding '' to the validation and adding if empty string to the if statement before applying the query.

Related ticket(s)

(Include the tickets that either came before, after, or are happening in tandem with this new ticket)

  • [ ]

Action item(s)

(These are the smaller tasks that should happen in order to complete this work)

  • All filters return all results when an empty string is queried

Completion criteria

(What does the end state look like - as long as this task(s) is done, this work is complete)

  • [ ]

References/resources/technical considerations

(Is there sample code or a screenshot you can include to highlight a particular issue? Here is where you reinforce why this work is important)

@cnlucas cnlucas moved this to 🔜 Sprint backlog in Website project Oct 18, 2024
@patphongs patphongs added this to the 26.6 milestone Oct 18, 2024
@pkfec pkfec self-assigned this Oct 22, 2024
@pkfec pkfec modified the milestones: 26.6, 26.5 Oct 22, 2024
@pkfec pkfec moved this from 🔜 Sprint backlog to 📥 Assigned in Website project Oct 22, 2024
@pkfec pkfec modified the milestones: 26.5, 26.6 Nov 5, 2024
@rfultz rfultz modified the milestones: 26.6, 26.i Nov 21, 2024
@pkfec pkfec modified the milestones: 26.i, 27.1 Dec 10, 2024
@pkfec pkfec linked a pull request Dec 19, 2024 that will close this issue
@pkfec pkfec linked a pull request Dec 19, 2024 that will close this issue
@rfultz rfultz modified the milestones: 27.1, 27.2 Dec 23, 2024
@rfultz rfultz modified the milestones: 27.2, 27.3 Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📥 Assigned
Development

Successfully merging a pull request may close this issue.

4 participants