Update memo text deletion to prevent stranding records

[exalate-issue-sync]

The API manages transaction memo texts in a way that could potentially lead to inconsistent behavior in the future.

Currently,

• if you delete a transaction, the memo text is not marked as soft deleted.
• If you update a transaction and give it a newly-blank memo text, the memo text record is soft-deleted, but then when you later add a new memo text, the record is still soft-deleted.

The assigned developer should update the API to resolve these issues.

QA Notes

This ticket involves updating behind-the-scenes behavior on the API. There should be no visible changes, but it would be good to verify the behavior around both transaction and report memo texts.

Transaction memos in particular should save and update as normal. You should be able to save a transaction with a memo text, update the memo text to be blank, and then add a new memo text again.

DEV Notes

• Update the Transaction model’s deletion method to soft delete any associated memo text record.
• Update the Transaction model so that saving a transaction with an empty memo text will hard delete any associated memo text record.
• Write new unit tests to verify this behavior.

Design

null

See full ticket and images here: FECFILE-1967

[exalate-issue-sync]

Elaine Krauss commented: The instructions in the DEV Notes were written based on a discussion with [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62]