Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Reload e-regs for 2019 11 CFR and rules published since #443

Closed
2 tasks
Tracked by #139
dorothyyeager opened this issue May 2, 2019 · 8 comments
Closed
2 tasks
Tracked by #139

Reload e-regs for 2019 11 CFR and rules published since #443

dorothyyeager opened this issue May 2, 2019 · 8 comments
Assignees
Milestone

Comments

@dorothyyeager
Copy link
Contributor

dorothyyeager commented May 2, 2019

What we are after
Making sure the e-regs are up to date for users.

Background
In the past few months, there have been some reg changes, so it's time to reload the e-regs.

Also, the xml file for the 2019 11 CFR is now available: https://www.govinfo.gov/content/pkg/CFR-2019-title11-vol1/xml/CFR-2019-title11-vol1.xml

To do

  • Reload the regulations.
  • Test in dev, stage and prod
@lbeaufort lbeaufort added this to the Sprint 9.1 milestone May 2, 2019
@dorothyyeager
Copy link
Contributor Author

dorothyyeager commented May 3, 2019

In case it's needed, here's the link to the point of entry rules: https://sers.fec.gov/fosers/showpdf.htm?docid=402849. GovInfo link is https://www.govinfo.gov/app/details/FR-2019-05-02/2019-08874.

@dorothyyeager dorothyyeager changed the title Reload regulations to update for new point of entry rules Reload e-regs for 2019 11 CFR and rules published since May 16, 2019
@AmyKort AmyKort modified the milestones: Sprint 9.1, Sprint 9.2 May 16, 2019
@dorothyyeager dorothyyeager modified the milestones: Sprint 9.1, Sprint 9.2 May 28, 2019
@dorothyyeager dorothyyeager assigned fec-jli and unassigned pkfec May 28, 2019
@fec-jli
Copy link
Contributor

fec-jli commented May 29, 2019

We try to load 2019 eregs data to 'dev' space. for some reasons, it loads both 2018 and 2019 data into dev eregs-db. we need figure out how to handle this issue.
1)remove the 2018 data from dev eregs db
0r 2) modify our regulation search to get rid of 2018 data.

finally, we remove 2018 data from fec-eregs-db and reindex regulations. the 'Search regulations' works.

@dorothyyeager
Copy link
Contributor Author

dorothyyeager commented May 30, 2019

The duplicate 2018 data was removed. Thank you @fec-jli and @qqss88 for your work on this.

Just tested the eregs in dev. All of the changes made to 11 CFR that were included in the 2019 edition are showing up properly.

The biggest issue I see (and it's in the current version on fec.gov too) is that links to the old GPO website need to be updated. They were pointing to GPO's old API at fdsys.gov but need to update to govinfo.gov:

Some old bugs we had in the 2018 e-regs remain. See these issues for background:
#393
#391

Let me know if I should test each section. I've clicked around various parts randomly and all seemed in order, and I checked through the regulations that were updated in 2018, and they are correct. The regulations that took effect in 2019 are not in this version, which was expected as we load the xml file that comes from the 2019 edition (which contains the rules as of 1/1/2019).

cc: @AmyKort @PaulClark2

@dorothyyeager
Copy link
Contributor Author

GovInfo API link seems to be https://api.govinfo.gov/docs/.

@fec-jli
Copy link
Contributor

fec-jli commented Jun 3, 2019

2019 eregs has been loaded to dev, stage, prod successfully. All look good except existing external link eregs issue #393.

@dorothyyeager
Copy link
Contributor Author

Thanks @fec-jli! Is this ticket ready to close?

@fec-jli
Copy link
Contributor

fec-jli commented Jun 3, 2019

@dorothyyeager yes , It can be closed. Thanks

@dorothyyeager
Copy link
Contributor Author

Closing this ticket as the e-regs for 2019 are now loaded. Thank you @fec-jli and @qqss88 for your work on this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants