[DONT MERGE YET] 6651-switch gunicorn worker type #6652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnlucas
requested review from
johnnyporkchops,
patphongs,
pkfec,
fec-jli,
hcaofec,
rfultz and
tmpayton
cnlucas
changed the title
cnlucas
removed request for
johnnyporkchops,
pkfec,
patphongs,
fec-jli,
hcaofec,
rfultz and
tmpayton
cnlucas
force-pushed
the
feature/switch-gunicorn-worker-threads
branch
from
932a9d8 to
2297617
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6652 +/- ##
========================================
Coverage 79.67% 79.67%
========================================
Files 236 236
Lines 5172 5172
========================================
Hits 4121 4121
Misses 1051 1051 ☔ View full report in Codecov by Sentry. |
|
How we are handling sessions is not thread safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
A great breakdown of the worker types and their uses here
Switches to gunicorn to gthread worker type, we are switching to this type because of the difficulty in configuration with gevent--but can switch back if we find this is not performant enough.
Required reviewers
1-2 devs
Impacted areas of the application
General components of the application that this PR will affect:
This will effect our connections to the CMS db
Related PRs
fecgov/openFEC#6112
How to test
You could load test, but there's limitations there since it's not sending requests to the db
Load testing has happened on openFEC and will be happening during the testing of the above PR as well