Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6649 AOs & MURs Fixes #6650

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Jan 23, 2025

Summary

(Include a summary of proposed changes and connect issue below)

Required reviewers

(Include who is required to review prior to merge. For example: One designer and two front end developer reviews are required prior to merge)

Impacted areas of the application

General components of the application that this PR will affect:

Screenshots

(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)

Related PRs

Related PRs against other branches:

branch PR
fix/other_pr link
feature/other_pr link

How to test

(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)

System architecture updates (if applicable)

(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)

@rfultz rfultz requested a review from patphongs January 23, 2025 17:46
@rfultz rfultz self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (479b7b6) to head (3eb3527).
Report is 7 commits behind head on release/public-20250128.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/public-20250128    #6650   +/-   ##
========================================================
  Coverage                    79.67%   79.67%           
========================================================
  Files                          236      236           
  Lines                         5172     5172           
========================================================
  Hits                          4121     4121           
  Misses                        1051     1051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rfultz rfultz changed the base branch from develop to release/public-20250128 January 23, 2025 21:13
Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfultz MURs work again case_citation_require_all is working correctly now. I still can't get the AO autosuggest list working locally, but I'm not sure if it's a problem on my local since it's working for you. I did not see any console errors from that. Will merge and check that it's working in stage.

@patphongs patphongs merged commit ea2faeb into release/public-20250128 Jan 24, 2025
3 checks passed
@patphongs
Copy link
Member

Autosuggest for AOs work in stage 🎉 We should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

AOs & MURs Fixes
2 participants