-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] replace "currentColor" with a color, any color, but a color #292
Comments
Thanks for opening this issue, @bernaferrari. I’m planning to add controls that will allow you to customize properties (like color and stroke width) from the website before downloading. This will hopefully address the issues you’ve been having 😸 |
Thanks (didn't realise there were a repo for the website! BTW I loved the dark mode!)! I would suggest keeping the default dark/white, and if someone wants, toggle to use the "current color". Unrelated, but there are a large number of open PR in Feather. May I ask why you haven't approved them? I've always been curious - and even thought for instance you abandoned the project, but the website getting dark mode shows otherwise. |
Since I don’t want to compromise the quality of the icon set, I like to thoroughly review each icon before adding it. And unfortunately, between school and work, I don’t have a lot of free time to review the overwhelming number of pull requests opened on Feather. |
It looks like feathericons.com doesn’t currently persist input settings to local storage. I can make sure to support local storage and have the reset button purge the cache so these kinds of issues don’t crop up for users in the future. 👍 My friend also noticed that the color input:
|
When using Pixelmator Pro, I need to open Feather SVG files and replace
currentColor
with#000000
. When developing to Android and converting SVG to Vector Drawables I need to do the same thing, else the tools won't work. I know it isn't a huge deal, there are scripts to automate and etc, but should them be necessary? This is the only icon pack I know that does this.It doesn't matter what I'm doing, the
currentColor
attr is always making me loose time. Therefore, I have a request, can't we replace all of them with a color, any color? #000000, for example. Would solve all my issues.The text was updated successfully, but these errors were encountered: