Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapted the function to work in GNU Octave #10

Open
tzvet opened this issue Apr 11, 2022 · 1 comment
Open

adapted the function to work in GNU Octave #10

tzvet opened this issue Apr 11, 2022 · 1 comment

Comments

@tzvet
Copy link

tzvet commented Apr 11, 2022

I made few changes such that abfload() works also to read the data under GNU Octave. There are some Matlab vs GNU Octave differences in the functions called in abfload() that do not make it work straight under GNU Octave.

I am not sure all header infos are there, though some seem to be read out and present.

But at least the raw data [d] & sampling interval [si] are properly read out.

If interested to merge the small changes, please make a sign.

@swharden
Copy link

Hi @tzvet, thank you for sharing these changes! I'm not the owner of this project, but I appreciate Octave and I wish to offer some suggestions to make this contribution easier to review for the primary maintainer or others wishing to learn from this work.

If you compare the difference between the current version of this repository and your version (the "diff"), green and red highlights indicate all the lines which were edited:

Unfortunately it appears that almost every line of the file was edited. 😅 Having hundreds of changed lines makes contributions very difficult to review, but it looks like most of these changes are just whitespace (increasing indentation by two spaces). Is this whitespace required for GNU Octave support? If not, I recommend reverting to the original whitespace so the only changed lines in the "diff" are the ones meaningful for adding GNU Octave support, making your changes easier to identify.

If interested to merge the small changes, please make a sign

I do not know if the maintainer wishes to merge these changes, but simplifying the "diff" would make them easier for the maintainer to review and arrive at a decision.

I hope my suggestion is helpful! I'm happy to help if you have any questions along the way. Good luck! 👍🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants