Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with PEP-567 #2

Closed
fantix opened this issue Mar 4, 2018 · 6 comments
Closed

Make it compatible with PEP-567 #2

fantix opened this issue Mar 4, 2018 · 6 comments

Comments

@fantix
Copy link
Owner

fantix commented Mar 4, 2018

PEP-567 is accepted for Python 3.7. We should make this library compatible. contextvars should replace this library.

@fantix
Copy link
Owner Author

fantix commented Sep 5, 2018

In c33d9fc I replaced the local implementation with upstream contextvars library, and added partial asyncio support.

@jjjacksn
Copy link
Contributor

jjjacksn commented Sep 6, 2018

@fantix will you be cutting a 0.2.0 release soon?

@fantix
Copy link
Owner Author

fantix commented Sep 7, 2018

Yes! Will do as soon as test is fixed.

@jjjacksn
Copy link
Contributor

jjjacksn commented Sep 7, 2018

Do you mean the failing travis build for master or some specific test failures? I believe there is an issue with python 3.7 in Travis CI's default configuration -- more specifically with Python 3.7 and Ubuntu 14.04. travis-ci/travis-ci#9815 describes a workaround. If you update .travis.yml to contain something like this, the build may pass.

python: 
  - 3.5
  - 3.6

matrix:
  include:
    - python: 3.7
      dist: xenial
      sudo: true

I'll go ahead and open a PR with this change.

@fantix
Copy link
Owner Author

fantix commented Sep 8, 2018

Yes that’s the one you fixed. Thanks a lot! I’ll push a release as soon as I’m back to my keyboard.

@fantix
Copy link
Owner Author

fantix commented Oct 24, 2018

Closing this now. We won't add the keyword argument context to loop methods. The rest is very close to PEP-567 in behavior.

@fantix fantix closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants