Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge TF2IDB and TF2II versions #29

Open
fakuivan opened this issue Aug 16, 2018 · 0 comments
Open

Merge TF2IDB and TF2II versions #29

fakuivan opened this issue Aug 16, 2018 · 0 comments

Comments

@fakuivan
Copy link
Owner

This plugin needs to be built for tf2ii and tf2idb separately because of name collisions occurring between some enums named the same way on both of their includes (on tf2idb, on tf2ii). This is just a compiler issue however and could be solved by just modifying the include files, both APIs can run simultaneously in one server.

Some options:

  • Use an intermediate include that redefines names before including them
    #define colliding_name api_colliding_name
    #include <api>
    #undef colliding_name
    #define colliding_name api2_colliding_name
    #include <api2>
    
    This will have to be done for each name that collides, and could break autocompletion on some scripting environments.
  • Patch the files in a precompile step.
  • Fork the repos and fix the issue for good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant