Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more complex conditions in apply cuts #114

Open
1 of 2 tasks
maxnoe opened this issue Jan 21, 2020 · 3 comments
Open
1 of 2 tasks

Support more complex conditions in apply cuts #114

maxnoe opened this issue Jan 21, 2020 · 3 comments
Milestone

Comments

@maxnoe
Copy link
Member

maxnoe commented Jan 21, 2020

  • Allow ranges, e.g. like
    - [>, 50]
    - [<=, 50000]
  • Allow logical or / not
@maxnoe
Copy link
Member Author

maxnoe commented Jan 22, 2020

Maybe also using pandas eval or numexpr directly for this like in the feature generation is a good idea

@maxnoe maxnoe added this to the v1.0.0 milestone Jan 22, 2020
@LukasNickel
Copy link
Collaborator

@LukasNickel
Copy link
Collaborator

How would the configuration syntax for the logical or conditions look like anyway?
I think the current syntax might be to limited for that. We could (if we go with eval/query) go for something like:

selection:
    - intensity > 50
    - num_islands < 5
    - width > 0 and width < 10
    - telescope == 'LST' or telescope == 'MST'
    - run == 1 or run == 5

This way every line equals one boolean expression and all of them are joined with a logical and.

But maybe there is a better, backwards compatible way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants