Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'core' is a pretty presumptious name #4

Open
adamchainz opened this issue May 5, 2017 · 2 comments
Open

'core' is a pretty presumptious name #4

adamchainz opened this issue May 5, 2017 · 2 comments

Comments

@adamchainz
Copy link
Contributor

On any python environment in which this installed, for which the instructions recommend the system python, import core will import the core of osc. This could clobber web apps which sometimes use a pattern where there's a core module with base classes for the app. I think the module should be renamed osc to match the package name in setup.py.

@adamchainz
Copy link
Contributor Author

Also as part of this it could use entry_points in setup rather than scripts

@cenalulu
Copy link
Contributor

cenalulu commented May 5, 2017

Thanks @adamchainz for the advice! We will re-organize the directory to address this issue.

graingert pushed a commit to graingert/OnlineSchemaChange that referenced this issue May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants