You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.
Currently if multiple plugins are loaded of the same type (aside from built-in plugins and plugins that allow multiple active instances of the same types - e.g. ConfigSources), PluginRegistry will fail, as it doesn't have a way to decide which one of those to use.
Currently if multiple plugins are loaded of the same type (aside from built-in plugins and plugins that allow multiple active instances of the same types - e.g.
ConfigSource
s),PluginRegistry
will fail, as it doesn't have a way to decide which one of those to use.Instead it should be configurable (via settings or via the configuration file) which plugin to use for each plugin type. Then
PluginRegistry::setCurrentSinglePlugins()
should use that information to pick the active plugin:https://github.com/facebookincubator/LogDevice/blob/e6424a70735b589d0be1ed8a25f7a273a2198df3/logdevice/common/plugin/PluginRegistry.cpp#L85-L88
It should also subscribe to config/setting changes so that you can reconfigure which plugin to use on the fly.
The text was updated successfully, but these errors were encountered: