Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do i need run-java.sh any more when my jdk version using jdk17 #119

Open
feofefo opened this issue Nov 9, 2023 · 3 comments
Open

do i need run-java.sh any more when my jdk version using jdk17 #119

feofefo opened this issue Nov 9, 2023 · 3 comments

Comments

@feofefo
Copy link

feofefo commented Nov 9, 2023

No description provided.

@rhuss
Copy link
Contributor

rhuss commented Nov 10, 2023

Probably not. The primary value of run-java.sh was to help get proper defaults for the Java 8 version before those got fixed. Java is much better these days when it comes to "container-awareness". Also, run-java.sh is not maintained actively, so I recommend moving away. It had its time, but now it's probably obsolete.

@feofefo
Copy link
Author

feofefo commented Nov 16, 2023

ok, thank you so much.

@grgrzybek
Copy link
Contributor

While #113 is attempting (not fully) to detect Cgroups v2, which is well handled/supported by JDK17 (and JDK 1.8 too for some time now), JVM sets the {{MaxHeapSize}} to 1/4 of max available memory. If we want more, we need -Xmx and run-java.sh is supposed to help with the calculations (for example with declarative {{JAVA_MAX_MEM_RATIO}}).

But {{run-java.sh}} is not only for detecting default mem/cpu settings. It also handles debugging options in quite standard way, handles standard support scripts (like {{run-env.sh}}) and does some detection about Java application/jar to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants