Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment rendering for sclasses #420

Merged
merged 2 commits into from
May 14, 2023
Merged

Fix comment rendering for sclasses #420

merged 2 commits into from
May 14, 2023

Conversation

reese
Copy link
Collaborator

@reese reese commented Mar 11, 2023

Closes #412

Classes and modules already use format_constant_body to format their class bodies in the same way. These same rules can be used for sclass nodes, which follow the same rules. This fixes a subtle bug that was misaligning comments at the beginning of sclass bodies.

@reese reese requested a review from fables-tales March 11, 2023 20:53
@reese reese merged commit 3b06f3c into trunk May 14, 2023
@reese reese deleted the reese-sclass branch May 14, 2023 16:32
reese added a commit that referenced this pull request Jul 21, 2023
fables-tales pushed a commit that referenced this pull request Jul 21, 2023
* Revert "Fix comment rendering for sclasses (#420)"

This reverts commit 3b06f3c.

* Add shellcheck-ignore

* Add a test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

comment on first method in a class << super block is aligned incorrectly
2 participants