Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloring started tasks #292

Open
fabiospampinato opened this issue Sep 13, 2020 · 17 comments
Open

Coloring started tasks #292

fabiospampinato opened this issue Sep 13, 2020 · 17 comments

Comments

@fabiospampinato
Copy link
Owner

As implemented in #268 this extension could color started tasks with a different color.

Preview: https://pasteboard.co/JqO134S.gif

Is that something that you'd want? If so add a "👍" to this post.

@CaptnCodr
Copy link

An extra symbol would be nice for the "started" state.
Maybe "⭕" as default. "Circle" because it's in progress.

@fsevenm
Copy link

fsevenm commented Nov 21, 2020

An extra symbol would be nice for the "started" state.
Maybe "o" as default. "Circle" because it's in progress.

Nice idea, IMO

@CaptnCodr
Copy link

CaptnCodr commented Dec 11, 2020

Maybe "⭕" as default. "Circle" because it's in progress.

Additionally, [o] and [O] could also be default in this category.

@fsevenm
Copy link

fsevenm commented Dec 30, 2020

I've updated the fork, updated the icon of started tasks, made it counted in statistic and also made it configurable in the settings as the others. These are some images that may help me visualize it.
Screenshot-20201230094510-898x174
The classic version:
Screenshot-20201230094223-827x166

You can try this enhancement now btw, it's at https://marketplace.visualstudio.com/items?itemName=fsevenm.vscode-todo-plus. Yes, I publish it in marketplace, but will take it down asap when the pr gets merged.

@CaptnCodr
Copy link

@fsevenm Could you also add the todo.timekeeping.started.enabled property to configure, as like the created and finished property?
To have the option to enable/disable the @started tag on the task and consistency over the states. I don't always have activated the time and don't want to have any tags on them. That would be great!

Overall it works fine on my machine. Thanks for the practical "preview".

@fsevenm
Copy link

fsevenm commented Dec 30, 2020

Yeah, forgot that one. It's nice idea. I'll update the extension soon.

@CaptnCodr
Copy link

CaptnCodr commented Dec 30, 2020

@fsevenm In addition: there's something different than the other states, see:
image
The dots configured color before the task when marked.

@fsevenm
Copy link

fsevenm commented Jan 13, 2021

@CaptnCodr Sorry, just come back here after a couple of weeks. I've just pushed an update to the extension. It allows you to disable @started tag via config.

And about the dots problem, I cannot reproduce that. It's just fine on mine. See this,
image

@CaptnCodr
Copy link

CaptnCodr commented Jan 13, 2021

This is great!

When you select the whole line then the colored dots appear:
image

Edit:
I enabled "show whitespaces" in vscode and there are always colored dots:
image

@fsevenm
Copy link

fsevenm commented Jan 14, 2021

@CaptnCodr It's weird, I enabled "Render Whitespace" and it's just fine.
Peek 2021-01-14 17-43

I am using VS Code 1.52.1 on linux machine. What's yours?

@CaptnCodr
Copy link

@fsevenm I'm using VS Code 1.52.1 on Windows.

@CaptnCodr
Copy link

Your newest preview (4.19.3) works as expected. Approved from me. 🙂

Thank you, @fsevenm. 👍

@fsevenm
Copy link

fsevenm commented Jan 14, 2021

Thank You @CaptnCodr. Glad to hear it works now. I was on Windows in virtualbox, so I was able to reproduce your issue and made a fix for that. It's only on Windows I guess.

@House-of-Leaves
Copy link

Thank you for this; having the started tasks coloured with a different icon is really helpful!

The only thing I've noted is that the number on the line for a Project that shows the number of pending tasks only takes into account tasks not started now, started tasks are not included in the count. I believe originally pending and started tasks were included in the count?

Apologies if I have missed this and it is switchable somewhere. Many thanks.

@fsevenm
Copy link

fsevenm commented Feb 20, 2021

@House-of-Leaves Did you mean the number of pending tasks in the status bar?

@House-of-Leaves
Copy link

@fsevenm Thank you for the swift reply. Sorry, I should have explained better.

Previously a project listing would have looked something like this:
todo-before

The top line with the project title would include the number of outstanding tasks in parentheses, in this case (2)

When using the new version with the different icon for started tasks, the same todo now looks like this:
todo-after

The number of outstanding tasks now shows (1)

Many thanks.

@House-of-Leaves
Copy link

I've figured out I can work around this by changing the settings to something like:

"todo.statistics.project.text": "(P:[pending] S:[doing])

It is whether it's possible to have a statistics token that is the sum of [pending] and [doing], as I presume [finished] is the sum of [done] and [cancelled]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants