Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta generator should check solution class loaded #250

Open
macta opened this issue Apr 2, 2019 · 2 comments
Open

Meta generator should check solution class loaded #250

macta opened this issue Apr 2, 2019 · 2 comments

Comments

@macta
Copy link
Contributor

macta commented Apr 2, 2019

Due to an iceberg bug, loading a branch might leave out the solution class - generation then skips this file silently and leads to a later Travis failure. Better to fail early on generation.

@bencoman
Copy link
Contributor

bencoman commented Jun 5, 2019

Is this random, or do you have a reproducible case? (even if intermittent e.g. only 1 in 10 occurrence)

@macta
Copy link
Contributor Author

macta commented Jun 5, 2019

I get it frequently in P7 - but I think its fixed in P8 as I sat with Guille at Pharo days and showed him numerous cases that he was able to capture and subsequently fix.

Moving classes from a tag (like WIP) into a new package was a big catalyst for this bug. As you do more, and solve a few solutions, and load branches and review others, you may see it too.

You can get something a bit different when we create the new packages (as the branch in git has no concept of the baseline to know to load a new package now reference in the baseline). This doesn't cuase the kind of failure I call out here though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants