-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Buttons on Popup/Notifications #477
Comments
Hi @GreenLunar , I like the idea of accepting/denying a connection from a notification, mainly because on some systems there's no systray area, and besides something is changing on this matter https://wiki.debian.org/Ayatana/IndicatorsTransition, https://lists.debian.org/debian-devel/2018/03/msg00506.html However I think that it should be configurable, users should choose what kind of pop-ups to display: normal (current pop-ups) or minimal (icons on the notification). We already talked about making the pop-ups smaller here #424 and I even prototyped a simpler pop-up, but I think this approach is better. |
Yes, making it configurable (optional) is a good idea. |
Partially done. On GTK based DEs works from Ubuntu >= 16. On KDE (and others probably) I need to figure out how to start dbus mainloop or attach to the existing dbus session in order to show buttons on the desktop notifications. But it's doable, i.e.: python3-notify2 exists on all major distros since at least ubuntu 16. Probably I'll add dekstop notifications using libnotify first, to replace systray balloon messages, and then study how to show buttons on notifications in all DEs. |
WIP. Until now we used Qt's systray notifications. They couldn't be disabled and didn't integrate well with non-Qt based Desktop Environments. Also we depended on the system tray availability, which is not always available (i3, phosh, ...). Now the user can choose to use Qt's notifications, the system notification service or disabled them completely. Pros: - The notification style is defined by the Desktop Environment. - Can be configured globally from the system settings. - In many DEs, the notifications are grouped into a single view. So if you miss any event, you can go there and check out what happened. - Now we can display notifications on DEs where we couldn't before. - It's a standard supported by major DEs. Cons: - Sometimes we can't connect to the D-Bus mainloop instance. We need to investigate it. TODO: - Deny/Allow new outgoing connections from the notifications, replacing the current pop-ups. Requested here: #468 , #476 and #477 .
Awesome! What about a "Details" or "More Info" button? So... What about a "Details" or "More Info" button?
|
Could be added, but these pop-ups don't offer many options. Out of the box, you can only display text and buttons, so no comboboxes, no checkboxes, no lists, etc. The "More info" could display all the fields of the connection, and there could be another button to open the GUI. |
Of course not. The "More Info" button will open the popup dialog that we currently have now |
Yeah, I haven't added it for this release, only system notifications without buttons. I need to figure out how to show the buttons in all DEs. |
Buttons are the most crucial part. |
Hello, I'm a happy ArchLinux user of OpenSnitch under Xfce desktop, and I want to ask for a new feature.
Following issue #476, I'd like to suggest to have an option to enable notification using a notification balloon.
The notification balloon would have 3 three buttons "Deny" "Allow" "Expert"
"Expert" button (or whatever name you have in mind) will open the popup dialog which we currently have.
Reason: Intrusiveness
While Notification Balloon will be on the top layer of the display, just as the current popup dialog, it will not be intrusive in the sense that it will not cause a fault of a current user's action.
Example: Intrusiveness
User is in the middle of adding tags to a bookmark in a web browser, and the popup dialog of OpenSnitch just caused it to be closed.
The text was updated successfully, but these errors were encountered: