Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too Many Terms #60

Open
JonathonMisiewicz opened this issue Mar 23, 2021 · 0 comments
Open

Too Many Terms #60

JonathonMisiewicz opened this issue Mar 23, 2021 · 0 comments
Labels
cleanup The code can be made a bit cleaner

Comments

@JonathonMisiewicz
Copy link
Contributor

QForte heavily abuses the word "terms". It's used in quantum_operator to mean a scalar multiple of QuantumCircuit. It's used in sq_op_pool to mean a scalar multiple ofSqOperator. It's used in sq_operator to mean a scalar multiple of vacuum-normal, particle-conserving products of fermionic second quantized operators.

As a result, trying to read certain sections of the code has proven an interminable headache. The offending methods should be given more descriptive names. This is, of course, another very API-breaking change.

@JonathonMisiewicz JonathonMisiewicz added the cleanup The code can be made a bit cleaner label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup The code can be made a bit cleaner
Projects
None yet
Development

No branches or pull requests

1 participant