Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get thee a linter #22

Open
jedwards1211 opened this issue Jun 26, 2016 · 2 comments
Open

get thee a linter #22

jedwards1211 opened this issue Jun 26, 2016 · 2 comments

Comments

@jedwards1211
Copy link

When I copied your source into my project, I got the following eslint errors:

/Users/andy/frcs-portal/jcore-react-components/meteor/ldap/LDAPAccountSupport.js
  200:33  error    'retObj' is not defined                   no-undef
  240:7   warning  'userOptions' is defined but never used   no-unused-vars
  260:9   warning  'stampedToken' is defined but never used  no-unused-vars
  279:14  error    'ldapObj' is not defined                  no-undef
  288:41  error    'ldapObj' is not defined                  no-undef
  291:9   error    'ldapObj' is not defined                  no-undef
  310:7   warning  Unexpected console statement              no-console

4 bugs waiting to happen that could have been easily prevented by using eslint.

@etyp
Copy link
Owner

etyp commented Dec 8, 2016

@jedwards1211 willing to merge in a PR with a linter if you submit. I don't use this in any of my projects anymore, so all I have time to do is maintain and support where I can.

@jedwards1211
Copy link
Author

@etyp Heh, unfortunately I didn't end up using this either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants