From ff4d13d35f4e9d12b004e152ea014d8e3dffa81d Mon Sep 17 00:00:00 2001
From: etianl <115842502+etianl@users.noreply.github.com>
Date: Tue, 6 Aug 2024 02:36:31 -0700
Subject: [PATCH]  1.1.5 BaseHunting/ChunkTracing Performance improved muchly

***Base Hunting Performance Muchly Improved!!!***
**BaseFinder**
- Switched to reading the block positions from chunk sections so we can easily skip sections that are empty or null.
- Switching to reading chunk sections like this has also massively improved performance with BaseFinder.
- Made Saving and Loading base chunks to disk not enabled by default because it's really not necessary.
- Fixed the slider range for Sky Build Finder, it's minimum and slider range were too high meaning it couldn't be configured for all situations properly.
- Set the default for "Render-Distance(Chunks)" to 128 from 512.
- Added a function to both **BaseFinder** and **NewerNewChunks** which removes chunks from RAM if they are outside of the "Render-Distance(Chunks)" setting. This only will occur if the SaveData and LoadData settings are off (other wise it'd mess up the saved data).
- The function above may massively improve performance. I did leave SaveData and LoadData enabled by default for **NewerNewChunks** so you don't lose chunk data but you can disable those options to gain the benefit from this function if you want to (Or just press the Delete Chunk Data button once in a while in the options for it).

**NewerNewChunks**
- The Palette checks for BlockStates now only happen on sections that are not empty to improve performance and reduce some false positives.
- NewerNewChunks now only checks the unique blockstates against palettes that are a BiMap Palette because those are the only kind used for new structure generation. Previously I was just checking it against every palette because my previous method reading bytes couldn't see what kind of palette it was.
- Made biome palette checking only occur in the End dimension where it's needed.
- Made the taskexecutor code gooder for loading chunk datas in both **NewerNewChunks** and **BaseFinder**.

Chunk tracing using **NewerNewChunks** with **BaseFinder** is now super smooth and lag free :D
---
 src/main/java/pwn/noobs/trouserstreak/modules/BaseFinder.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/pwn/noobs/trouserstreak/modules/BaseFinder.java b/src/main/java/pwn/noobs/trouserstreak/modules/BaseFinder.java
index 4ff506f2..4ecb9b13 100644
--- a/src/main/java/pwn/noobs/trouserstreak/modules/BaseFinder.java
+++ b/src/main/java/pwn/noobs/trouserstreak/modules/BaseFinder.java
@@ -708,7 +708,7 @@ private void onReadPacket(PacketEvent.Receive event) {
                                 for (int y = 0; y < 16; y++) {
                                     for (int z = 0; z < 16; z++) {
                                         int currentY = Y + y;
-                                        if (currentY < Ymin || currentY > Ymax) continue;
+                                        if (currentY <= Ymin || currentY >= Ymax) continue;
                                         blockposi=new BlockPos(x, currentY, z);
                                         BlockState blerks = section.getBlockState(x,y,z);
                                         if (blerks.getBlock()!=Blocks.AIR){