core: align overflow checks in IntrinsicGas #30931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
reviewed
Dec 18, 2024
|
Similarly, auths from 7702 have sufficient size that the overflow checks this EIP adds can never realistically be triggered there either. |
True, but it might make sense to align handling of those checks. See also this comment. |
|
@rjl493456442 As you advocated for this in #30880 (comment) , it would be nice to either get a go or no-go. Feel free to close if there isn't consensus for this change. |
|
We have made up our mind, and do not want to reduce the readability of the code for a case that cannot happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30880
This PR fixes calculations in the IntrinsicGas function that do not care abount overflow, ensuring they handle overflow in the same way as other computations in the same function