-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-2935: Historical Block Hashes from State #510
Comments
does this require a noop spec if the feature is not implemented for use in isthmus, or will nothing break if it is skipped @protolambda ? |
We would need to have the enabled on L2s for interop, so I would expect it would be implemented and enabled as part of supporting Pectra in OP Stack (but not needed as part of making OP Stack work when pectra is enabled on the L1). |
ok thanks @ajsutton , so it doesn't require any action if not included in isthmus because lack of time, capisci |
Is Isthmus activating pectra on L2? We aren't picking and choosing bits of pectra to enable other than where things just don't apply. But for things that make sense on L2 we are either activating all of pectra or none of it. |
I thought there would just be one hard fork called isthmus, but I'm also the completely wrong person to ask. I think some Pectra issues have to be addressed to ensure nothing breaks when l1 forks, see issues labelled noop. |
Yeah there are two parts to "supporting pectra". The highest priority is making sure that pectra can be enabled on the L1 and not have things break - that's the stuff around how to parse new transaction types. The other part is actually enabling pectra on the L2 chain. That will be done in a future hard fork - possibly Isthmus but it depends when it's actually ready. We "include" L1 hard forks in an L2 hard fork which in terms of the geth config means you'd have |
With the beacon-root history accumulator contract in the previous L1 upgrade, very similar to the new block-hash accumulator contract, we used a trick with deposits to deploy the contract automatically as part of the upgrade, in case it's not already permissionlessly deployed. I would strongly recommend we do the same type of thing this upgrade. And then as @ajsutton said, if the pectra functionality is properly enabled as part of the L2 upgrade, then the block-hashes will be applied to the block-hash contract as expected. |
Description
EIP-2935 serves historical block hashes from state. Effectively a new contract is deployed to track the previous
8192
block hashes.This EIP:
8191
block hashes in the service window so the lookup is a sliding8191
window of block hashes.References
The text was updated successfully, but these errors were encountered: