Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannon64: Migrate 32-bit tests to be forward-compatible #12598

Closed
mbaxter opened this issue Oct 23, 2024 · 1 comment · Fixed by #12839
Closed

Cannon64: Migrate 32-bit tests to be forward-compatible #12598

mbaxter opened this issue Oct 23, 2024 · 1 comment · Fixed by #12839
Assignees
@Inphi
Labels
A-cannon Area: cannon MT-Cannon STF code complete

Comments

@mbaxter
Copy link
Contributor

mbaxter commented Oct 23, 2024

Description

After enabling 64-bit tests in CI (#12252), which will likely involve skipping failing tests temporarily, rework failing 32-bit tests to be forward-compatible with 64-bit Cannon.

When this ticket is complete, we should no longer be skipping any relevant tests for the 64-bit VM.
@mbaxter mbaxter mentioned this issue Oct 23, 2024
Merged
@Inphi
Copy link
Contributor

Inphi commented Oct 24, 2024

#12032 partially blocks this. We can begin the work of migrating existing 32-bit tests. But newly added 32-bit tests will have to be forward compatible as well. This issue cannot be completed until #12032 is complete and the tests introduced are forwards-compatible.

@mbaxter mbaxter mentioned this issue Oct 29, 2024
Merged
@Inphi Inphi self-assigned this Oct 30, 2024
@Inphi Inphi moved this from TO-DO to In progress in Proofs team - Project Delivery tracking board Oct 30, 2024
@mbaxter mbaxter mentioned this issue Oct 31, 2024
Merged
@Inphi Inphi mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Inphi Inphi

Labels
A-cannon Area: cannon MT-Cannon STF code complete
Projects
Proofs team - Project Delivery tracking board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cannon: Add more 64-bit tests ethereum-optimism/optimism
2 participants
@mbaxter @Inphi