You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Kona was recently updated to use rv64ima architecture which doesn't contain instruction sets like zicsr.
However, the tests in riscv-test contain test macros that rely on the usage of such csr instructions. As such, test vectors in the riscv-test cannot be built for rv64ima and will fail upon building with custom riscv toolchain built for rv64ima. See this open issue: riscv-software-src/riscv-tests#368.
This means that we should keep the CSR instructions or at least NOOP them (since they aren't used in actual kona binary) in the vm to support riscv-test.
If we would like to remove these CSR instructions, since we would still want to test asterisc implementation against the official test vectors, we should consider either:
keeping this specific instruction set zicsr for testing purposes even though it isn't used in kona's binary
contribute to upstream riscv-test repository to support building with rv64ima
remove the test suites
The text was updated successfully, but these errors were encountered:
Asterisc has riscv-test which are test vectors provided by the official riscv organization.
Kona was recently updated to use rv64ima architecture which doesn't contain instruction sets like
zicsr
.However, the tests in riscv-test contain test macros that rely on the usage of such csr instructions. As such, test vectors in the riscv-test cannot be built for
rv64ima
and will fail upon building with custom riscv toolchain built forrv64ima
. See this open issue: riscv-software-src/riscv-tests#368.This means that we should keep the CSR instructions or at least NOOP them (since they aren't used in actual kona binary) in the vm to support riscv-test.
If we would like to remove these CSR instructions, since we would still want to test asterisc implementation against the official test vectors, we should consider either:
zicsr
for testing purposes even though it isn't used in kona's binaryThe text was updated successfully, but these errors were encountered: