Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reiscv-test test vectors #130

Open
mininny opened this issue Jan 17, 2025 · 0 comments
Open

Update reiscv-test test vectors #130

mininny opened this issue Jan 17, 2025 · 0 comments

Comments

@mininny
Copy link
Collaborator

mininny commented Jan 17, 2025

Asterisc has riscv-test which are test vectors provided by the official riscv organization.

Kona was recently updated to use rv64ima architecture which doesn't contain instruction sets like zicsr.

However, the tests in riscv-test contain test macros that rely on the usage of such csr instructions. As such, test vectors in the riscv-test cannot be built for rv64ima and will fail upon building with custom riscv toolchain built for rv64ima. See this open issue: riscv-software-src/riscv-tests#368.

This means that we should keep the CSR instructions or at least NOOP them (since they aren't used in actual kona binary) in the vm to support riscv-test.

If we would like to remove these CSR instructions, since we would still want to test asterisc implementation against the official test vectors, we should consider either:

  • keeping this specific instruction set zicsr for testing purposes even though it isn't used in kona's binary
  • contribute to upstream riscv-test repository to support building with rv64ima
  • remove the test suites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant