From 9d9ad0046ed4e2efb4c8c0ea9b30f4f65f7cd7f9 Mon Sep 17 00:00:00 2001 From: clabby Date: Tue, 19 Nov 2024 19:31:27 -0500 Subject: [PATCH] check out submodules in rvsol CI --- .github/workflows/ci.yaml | 2 ++ rvsol/src/RISCV.sol | 10 ++-------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a27e723d..0d7e8b79 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -35,6 +35,8 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v4 + with: + submodules: recursive - name: Install Golang uses: actions/setup-go@v5 with: diff --git a/rvsol/src/RISCV.sol b/rvsol/src/RISCV.sol index 0f744785..70be3ebf 100644 --- a/rvsol/src/RISCV.sol +++ b/rvsol/src/RISCV.sol @@ -11,7 +11,7 @@ import { IBigStepper } from "@optimism/src/dispute/interfaces/IBigStepper.sol"; /// @dev https://github.com/ethereum-optimism/asterisc contract RISCV is IBigStepper { /// @notice The preimage oracle contract. - IPreimageOracle internal immutable ORACLE; + IPreimageOracle public oracle; /// @notice The version of the contract. /// @custom:semver 1.1.0-rc.1 @@ -19,13 +19,7 @@ contract RISCV is IBigStepper { /// @param _oracle The preimage oracle contract. constructor(IPreimageOracle _oracle) { - ORACLE = _oracle; - } - - /// @notice Getter for the pre-image oracle contract. - /// @return oracle_ The pre-image oracle contract. - function oracle() external view returns (IPreimageOracle oracle_) { - oracle_ = ORACLE; + oracle = _oracle; } /// @inheritdoc IBigStepper