etcdserver: add learner check to readyz #19086
Conversation
|
Hi @gojoy. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
gojoy
force-pushed
the
readyz-learner
branch
from
9bdee08 to
58de027
Compare
|
@siyuanfoundation Hi. Can you review this request |
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 54 files with indirect coverage changes @@ Coverage Diff @@
## main #19086 +/- ##
==========================================
+ Coverage 68.75% 68.82% +0.06%
==========================================
Files 420 420
Lines 35640 35655 +15
==========================================
+ Hits 24506 24538 +32
+ Misses 9705 9695 -10
+ Partials 1429 1422 -7 Continue to review full report in Codecov by Sentry.
|
|
lgtm overall. Can you fix the tiny error in the verify test? |
|
/retest-required |
done |
error in the verify test has been fixed. please review again @siyuanfoundation |
|
Hi ,Can you review this request? Thanks! @siyuanfoundation |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: GitHub <[email protected]>
|
/retest-required |
|
cc @serathius |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, gojoy, serathius, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix #19001