Mises à jour techniques (Elixir, Erlang, NVM, NodeJS) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI already does that by default.
thbar
changed the title
thbar
changed the title
2 tasks
|
Je temporise au profit de etalab/transport-site#2033 car je ne veux pas bloquer le travail de migration Netex parce qu'on veut mettre à jour Elixir etc. |
|
Je passe en brouillon, il faudra revoir la copie et faire plusieurs petites PR. |
|
(je ré-ouvre) |
thbar
changed the title
|
#2033 étant finalisé et déployé, j'ai repris en main cette PR, et je remets quelques versions à jour pour finaliser. |
thbar
commented
Feb 9, 2022
| TEST_EXPECTED_NODE_OUTPUT: "v14.16.1" | ||
| TEST_EXPECTED_ELIXIR_OUTPUT: "Elixir 1.12.2 (compiled with Erlang/OTP 24)" | ||
| TEST_EXPECTED_ERLANG_OUTPUT: "Erlang/OTP 24" | ||
| TEST_EXPECTED_NODE_OUTPUT: "v16.14.0" |
There was a problem hiding this comment.
Il faudra vérifier la compatibilité du côté site.
thbar
commented
Feb 9, 2022
| TEST_EXPECTED_ERLANG_OUTPUT: "Erlang/OTP 24" | ||
| TEST_EXPECTED_NODE_OUTPUT: "v16.14.0" | ||
| TEST_EXPECTED_ELIXIR_OUTPUT: "Elixir 1.13.2 (compiled with Erlang/OTP 24)" | ||
| TEST_EXPECTED_ERLANG_OUTPUT: "24.2.1" |
There was a problem hiding this comment.
Attention on fait un "gros saut" sur OTP, il faudra être vigilant (aspects HTTP etc).
thbar
commented
Feb 9, 2022
| - name: Test that Erlang can start and has (major) expected version | ||
| run: docker run --rm ${{ env.TEST_TAG }} /bin/bash -c "erl -noshell -eval 'erlang:display(erlang:system_info(system_version))' -eval 'init:stop()'" | grep '${{ env.TEST_EXPECTED_ERLANG_OUTPUT }}' | ||
| - name: Test that Erlang can start and has expected version (major + minor + optional revision number) | ||
| run: docker run --rm ${{ env.TEST_TAG }} /bin/bash -c "erl -eval '{ok, Version} = file:read_file(filename:join([code:root_dir(), \"releases\", erlang:system_info(otp_release), \"OTP_VERSION\"])), io:fwrite(Version), halt().' -noshell" | grep '${{ env.TEST_EXPECTED_ERLANG_OUTPUT }}' |
There was a problem hiding this comment.
Le test ci-dessus est amélioré et vérifie la totalité de la version (24.2.1 plutôt que juste 24).
This was referenced Feb 9, 2022
4 tasks
thbar
added a commit
that referenced
this pull request
Feb 24, 2022
* Mises à jour techniques (Elixir, Erlang, NVM, NodeJS) (#33) * Make sure the docker hub link is closer from the image * Update to most recent elixir/erlang couple * Bump NVM to latest https://github.com/nvm-sh/nvm/releases * Bump NodeJS to latest LTS available https://nodejs.org * Try to fix the build * Update test for NodeJS * Update test for Elixir version * Modify script to make it work with newer format * Add readme test to verify OTP version in full (improved) * Update GitHub action to assert on full version * Now use full version specifier * Add explanation about how the hex images are built * Add very useful help to see output of commands locally The CI already does that by default. * Upgrade packages (except kernel) for security See etalab/transport-deploy#46 for context * Bump to latest * Bump Node to latest LTS * Bump tests * Elixir 1.12.2 et transport-tools 1.0.3 * Update rakefile Co-authored-by: Thibaut Barrère <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans cette PR, de nombreuses mises à jour, et aussi des améliorations sur la build, le test, et un peu la sécurité.
L'acceptation de cette PR ne modifiera pas la version utilisée dans l'application, elle permettra simplement que je prépare une release de l'image de départ, que je pousserai par ailleurs sur Docker après avoir créé une release.
Ca veut dire qu'on contrôle le timing sans souci.
Améliorations de la build
apt-get upgradepour mettre à jour ce qui peut l'être dans la partie Ubuntu. C'é'tait utile en pratique. Voir https://github.com/etalab/transport_deploy/issues/46 pour plus de contexte.Mises à jour
Map.filter/2🥳). Pour les changements, voir dans l'ordre:~/.nvmsinon ça ne marchait plus.