Check in poetry.lock into source control (PACMAN-637)

[corpix]

Related area

git

Is your feature request related to a problem?

There is no lock file in source control. This makes packaging this tool difficult (I do update this environment https://github.com/mirrexagon/nixpkgs-esp-dev)

Describe the solution you'd like

I see .gitignore says poetry.lock was removed because of tests. Maybe this could be done during test environment preparation?

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and I have provided enough information.

• I confirm I have checked existing list of Feature requests and I have provided enough information.

[kumekay]

Hello @corpix

Thank you so much for your efforts supporting Espressif tools for Nix!

Even though we recently added poetry, so far, we only use it to setup the local development environment. For packaging, we still rely on the (good) old setup.py
https://github.com/espressif/idf-component-manager/blob/main/publish.sh#L15

One of the reasons we didn't switch to poetry entirely is the fact we still support python 2.7 and 3.5. And we are planning to do so until EOL of ESP-IDF 4.3 this December.

IIRC, we decided to exclude poetry.lock, because the lock file does not always work on all platforms and different Python versions, because not all packages provide all the metadata on PyPI.

What is your main difficulty with packaging the component manager for nix? Could you use setup.py there?

[corpix]

Thanks for the reply!
I think I could, will try, thank you for the explanation!

[kumekay]

@corpix In a coming release of 2.0.0 we will remove setup.py, but still won't add a lock file. What is the main problem of packaging without a lock file?

[kumekay]

@corpix I would like to close this issue now, however you are welcome to reopen if you want to discuss this topic further.