Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAbookreader ZOOM functionality parsing URL fails on File Names (IIIF IDs) that contain the word FULL #467

Closed
DiegoPino opened this issue Sep 17, 2024 · 1 comment
Closed

IAbookreader ZOOM functionality parsing URL fails on File Names (IIIF IDs) that contain the word FULL #467

DiegoPino opened this issue Sep 17, 2024 · 1 comment
Assignees
@DiegoPino
Labels
bug Something isn't working Field Formatter The thing that glues the pieces and adds glitter IIIF Specs/Manifests/Implementations Javascript Favourite language of a PHP developer
Milestone
1.5.0

Comments

@DiegoPino
Copy link
Member

What?

A hard to hit issue.

If your PDF (or image) contains the word "full" in its name, the OSD overlay won't be able to split the URL correctly ending with a broken Overlay.

Fix is to use a stricter IIIF aware parsing mechanism (a maybe even deal with non IIIF images too?)

Regular expressions and splitting. Maybe even a IIIF URL parser function helper
@DiegoPino DiegoPino self-assigned this Sep 17, 2024
@DiegoPino DiegoPino added bug Something isn't working Javascript Favourite language of a PHP developer IIIF Specs/Manifests/Implementations Field Formatter The thing that glues the pieces and adds glitter labels Sep 17, 2024
@DiegoPino DiegoPino added this to the 1.5.0 milestone Sep 17, 2024
DiegoPino added a commit that referenced this issue Sep 19, 2024
@DiegoPino
More consistent parsing of IIIF Info JSON for IABookreader page source
11fa9bb 
for zoom see #467
@DiegoPino
Copy link
Member Author

Fixed via #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
bug Something isn't working Field Formatter The thing that glues the pieces and adds glitter IIIF Specs/Manifests/Implementations Javascript Favourite language of a PHP developer
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@DiegoPino