Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PSTH method #295

Closed
tensionhead opened this issue Jun 13, 2022 · 4 comments · Fixed by #381
Closed

Implement PSTH method #295

tensionhead opened this issue Jun 13, 2022 · 4 comments · Fixed by #381
Assignees
@tensionhead
Labels
Feature Request A concrete request (as detailed as possible) to either add or change functionality.
Milestone
timelockanalysis

Comments

@tensionhead
Copy link
Contributor

Even though we have also #169 , psth as a basic method is still needed.
@tensionhead tensionhead added the Feature Request A concrete request (as detailed as possible) to either add or change functionality. label Jun 13, 2022
@tensionhead tensionhead added this to the timelockanalysis milestone Jun 13, 2022
@tensionhead tensionhead self-assigned this Jun 13, 2022
@tensionhead
Copy link
Contributor Author

This now also entails designing a TimeLockData datatype

@tensionhead tensionhead mentioned this issue Aug 23, 2022
Merged
14 tasks
@tensionhead
Copy link
Contributor Author

Basic functionality is done with #339 , proper tests and support for different output s is still missing

@tensionhead
Copy link
Contributor Author

Tests got also merged with #347 , now what remains is the .avg which is part of #341

tensionhead added a commit that referenced this issue Nov 28, 2022
@tensionhead
NEW: PSTH complete with avg and var
2bcbf34 
- was straightforward as it's basically timelockanalysis once the
histogramsa are around
- trials statistics tested via plotting as before for a single trial
- closes #295

Changes to be committed:
	modified:   syncopy/statistics/spike_psth.py
	modified:   syncopy/tests/test_spike_psth.py
@tensionhead tensionhead linked a pull request Nov 28, 2022 that will close this issue
Timelockanalysis + PSTH finish #381
Merged
15 tasks
@tensionhead
Copy link
Contributor Author

Finally done with #381 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tensionhead tensionhead

Labels
Feature Request A concrete request (as detailed as possible) to either add or change functionality.
Projects
None yet
Milestone
timelockanalysis
Development

Successfully merging a pull request may close this issue.

Timelockanalysis + PSTH finish esi-neuroscience/syncopy
1 participant
@tensionhead