Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uri-js #60

Open
valadaptive opened this issue Jun 29, 2024 · 5 comments · Fixed by es-tooling/module-replacements#70
Open

Replace uri-js #60

valadaptive opened this issue Jun 29, 2024 · 5 comments · Fixed by es-tooling/module-replacements#70
Labels
umbrella issue This issue contains a list of dependents of a package and tracks the progress in each

Comments

@valadaptive
Copy link

uri-js is supposed to use the punycode package, but it accidentally imports the Node builtin instead, which now prints an annoying deprecation warning in everyone's console.

This is reported upstream as garycourt/uri-js#95, but the original maintainer appears to have gone AWOL. Replacing uri-js in downstream repositories would solve this annoying issue.

I believe that the built-in JS URL global supports most, if not all, use cases, but I'm not sure if any projects rely on any subtle semantics or how the WHATWG URL standard differs exactly from RFC 3986.

@valadaptive
Copy link
Author

ajv replaced it with https://github.com/fastify/fast-uri

@AbhiPrasad
Copy link

ajv update: ajv-validator/ajv#2460

@AbhiPrasad
Copy link

https://github.com/andreinwald/uri-js-replace is another replacement

@AbhiPrasad
Copy link

PR'd here: es-tooling/module-replacements#70

@43081j
Copy link
Collaborator

43081j commented Jul 1, 2024

reopening since we can still use this to track replacing it in upstream repos 👍

@43081j 43081j reopened this Jul 1, 2024
@Fuzzyma Fuzzyma added the umbrella issue This issue contains a list of dependents of a package and tracks the progress in each label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella issue This issue contains a list of dependents of a package and tracks the progress in each
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants