Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode_lower_table / unicode_upper_table should be deprecated #42

Open
Oreolek opened this issue Nov 6, 2019 · 1 comment
Open

unicode_lower_table / unicode_upper_table should be deprecated #42

Oreolek opened this issue Nov 6, 2019 · 1 comment

Comments

@Oreolek
Copy link

Oreolek commented Nov 6, 2019

Modern JS (since circa 2014) has proper String.toLowerCase and String.toUpperCase methods and they are Unicode-aware. Quixe tables are not really Unicode-aware, they fail on non-Latin scripts.

File in question:

var unicode_upper_table = {

@Oreolek Oreolek changed the title unicode_lower_table should be deprecated unicode_lower_table / unicode_upper_table should be deprecated Nov 6, 2019
@erkyrath
Copy link
Owner

erkyrath commented Nov 7, 2019

I am somewhat torn between using the JS facility for Unicode or sticking with my old implementation, which will behave consistently with the C interpreters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants