Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GiLoad will download the story file even if it's provided #38

Open
curiousdannii opened this issue Sep 27, 2018 · 3 comments
Open

GiLoad will download the story file even if it's provided #38

curiousdannii opened this issue Sep 27, 2018 · 3 comments

Comments

@curiousdannii
Copy link
Contributor

quixe/src/quixe/gi_load.js

Lines 221 to 223 in 12d43e1

if (!gameurl && image) {
/* The story data is already loaded -- it's not an a URL at all.
Decode it, and then fire it off. */

This should just be if (image) { shouldn't it?

@erkyrath
Copy link
Owner

erkyrath commented Oct 3, 2018

I think I decided that, since the ?story= parameter can be added after the fact, it should override the image configuration parameter.

@curiousdannii
Copy link
Contributor Author

Do you mean through the Web History API (history.pushState)? That's an odd use case, but okay.

I'd like to be able to use GiLoad in Parchment without modification and be able to pass it the image buffer to use. So maybe there could be an extra option to say to not download it if ?story exists, or the reverse (I'd prefer explicit opt-in to overriding the image, but your choice.)

@erkyrath
Copy link
Owner

By "after the fact", I meant by the user, typing manually in the URL bar. Or by any page that generates a URL for the user to click on, referring to an established interpreter setup.

If you're passing in the image buffer, shouldn't gameurl be null?

(Apologies for the long response time, things slip by.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants