Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing for evaluation #7

Open
eric-unc opened this issue Mar 21, 2021 · 5 comments
Open

Unit testing for evaluation #7

eric-unc opened this issue Mar 21, 2021 · 5 comments

Comments

@eric-unc
Copy link
Owner

No description provided.

@harryzcy
Copy link
Collaborator

In tests, I think we need to check the result somehow?

@eric-unc
Copy link
Owner Author

Most certainly, although this is a fair amount of work.

@harryzcy
Copy link
Collaborator

Since eval doesn't return anything, it wouldn't be possible to test the result. Maybe make eval_expr or eval_expr_list public? Only these return LimpValue.

@eric-unc
Copy link
Owner Author

Dunno about public, since that stuff should be internal, but looks like Rust has a concept of pub(crate) that might be relevant. If you are interested I can leave you in charge of it, I am mostly testing stuff on the fly rn.

@harryzcy
Copy link
Collaborator

well, I'll take a look a bit later then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants