Fix: Adjust Methods\FinalInAbstractClassRule to ignore Doctrine entities

ergebnis · Dec 1, 2024 · c873637 · c873637
1 parent 449466b
commit c873637
Show file tree

Hide file tree

Showing 21 changed files with 372 additions and 0 deletions.
diff --git a/...le/Failure/AbstractClassWithProtectedMethodAndWithoutEntityAnnotationInInlineDocBlock.php b/...le/Failure/AbstractClassWithProtectedMethodAndWithoutEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Failure;
+
+/** @eNtItY */
+abstract class AbstractClassWithProtectedMethodAndWithoutEntityAnnotationInInlineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...Failure/AbstractClassWithProtectedMethodAndWithoutEntityAnnotationInMultilineDocBlock.php b/...Failure/AbstractClassWithProtectedMethodAndWithoutEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Failure;
+
+/**
+ * @eNtItY
+ */
+abstract class AbstractClassWithProtectedMethodAndWithoutEntityAnnotationInMultilineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...Failure/AbstractClassWithProtectedMethodAndWithoutOrmEntityAnnotationInInlineDocBlock.php b/...Failure/AbstractClassWithProtectedMethodAndWithoutOrmEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Failure;
+
+/** @OrM\eNtItY */
+abstract class AbstractClassWithProtectedMethodAndWithoutOrmEntityAnnotationInInlineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...lure/AbstractClassWithProtectedMethodAndWithoutOrmEntityAnnotationInMultilineDocBlock.php b/...lure/AbstractClassWithProtectedMethodAndWithoutOrmEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Failure;
+
+/**
+ * @OrM\eNtItY
+ */
+abstract class AbstractClassWithProtectedMethodAndWithoutOrmEntityAnnotationInMultilineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...sRule/Failure/AbstractClassWithPublicMethodAndWithoutEntityAnnotationInInlineDocBlock.php b/...sRule/Failure/AbstractClassWithPublicMethodAndWithoutEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Failure;
+
+/** @eNtItY */
+abstract class AbstractClassWithPublicMethodAndWithoutEntityAnnotationInInlineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...le/Failure/AbstractClassWithPublicMethodAndWithoutEntityAnnotationInMultilineDocBlock.php b/...le/Failure/AbstractClassWithPublicMethodAndWithoutEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Failure;
+
+/**
+ * @eNtItY
+ */
+abstract class AbstractClassWithPublicMethodAndWithoutEntityAnnotationInMultilineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...le/Failure/AbstractClassWithPublicMethodAndWithoutOrmEntityAnnotationInInlineDocBlock.php b/...le/Failure/AbstractClassWithPublicMethodAndWithoutOrmEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Failure;
+
+/** @OrM\eNtItY */
+abstract class AbstractClassWithPublicMethodAndWithoutOrmEntityAnnotationInInlineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...Failure/AbstractClassWithPublicMethodAndWithoutOrmEntityAnnotationInMultilineDocBlock.php b/...Failure/AbstractClassWithPublicMethodAndWithoutOrmEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Failure;
+
+/**
+ * @OrM\eNtItY
+ */
+abstract class AbstractClassWithPublicMethodAndWithoutOrmEntityAnnotationInMultilineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...ClassRule/Success/AbstractClassWithProtectedMethodAndEntityAnnotationInInlineDocBlock.php b/...ClassRule/Success/AbstractClassWithProtectedMethodAndEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/** @Entity */
+abstract class AbstractClassWithProtectedMethodAndEntityAnnotationInInlineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...ssRule/Success/AbstractClassWithProtectedMethodAndEntityAnnotationInMultilineDocBlock.php b/...ssRule/Success/AbstractClassWithProtectedMethodAndEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/**
+ * @Entity
+ */
+abstract class AbstractClassWithProtectedMethodAndEntityAnnotationInMultilineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...ssRule/Success/AbstractClassWithProtectedMethodAndOrmEntityAnnotationInInlineDocBlock.php b/...ssRule/Success/AbstractClassWithProtectedMethodAndOrmEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/** @ORM\Entity */
+abstract class AbstractClassWithProtectedMethodAndOrmEntityAnnotationInInlineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...ule/Success/AbstractClassWithProtectedMethodAndOrmEntityAnnotationInMultilineDocBlock.php b/...ule/Success/AbstractClassWithProtectedMethodAndOrmEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/**
+ * @ORM\Entity
+ */
+abstract class AbstractClassWithProtectedMethodAndOrmEntityAnnotationInMultilineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...Success/AbstractClassWithProtectedMethodAndOrmMappingEntityAnnotationInInlineDocBlock.php b/...Success/AbstractClassWithProtectedMethodAndOrmMappingEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/** @ORM\Mapping\Entity */
+abstract class AbstractClassWithProtectedMethodAndOrmMappingEntityAnnotationInInlineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...cess/AbstractClassWithProtectedMethodAndOrmMappingEntityAnnotationInMultilineDocBlock.php b/...cess/AbstractClassWithProtectedMethodAndOrmMappingEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/**
+ * @ORM\Mapping\Entity
+ */
+abstract class AbstractClassWithProtectedMethodAndOrmMappingEntityAnnotationInMultilineDocBlock
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/...actClassRule/Success/AbstractClassWithPublicMethodAndEntityAnnotationInInlineDocBlock.php b/...actClassRule/Success/AbstractClassWithPublicMethodAndEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/** @Entity */
+abstract class AbstractClassWithPublicMethodAndEntityAnnotationInInlineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...ClassRule/Success/AbstractClassWithPublicMethodAndEntityAnnotationInMultilineDocBlock.php b/...ClassRule/Success/AbstractClassWithPublicMethodAndEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/**
+ * @Entity
+ */
+abstract class AbstractClassWithPublicMethodAndEntityAnnotationInMultilineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...ClassRule/Success/AbstractClassWithPublicMethodAndOrmEntityAnnotationInInlineDocBlock.php b/...ClassRule/Success/AbstractClassWithPublicMethodAndOrmEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/** @ORM\Entity */
+abstract class AbstractClassWithPublicMethodAndOrmEntityAnnotationInInlineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...ssRule/Success/AbstractClassWithPublicMethodAndOrmEntityAnnotationInMultilineDocBlock.php b/...ssRule/Success/AbstractClassWithPublicMethodAndOrmEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/**
+ * @ORM\Entity
+ */
+abstract class AbstractClassWithPublicMethodAndOrmEntityAnnotationInMultilineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...le/Success/AbstractClassWithPublicMethodAndOrmMappingEntityAnnotationInInlineDocBlock.php b/...le/Success/AbstractClassWithPublicMethodAndOrmMappingEntityAnnotationInInlineDocBlock.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/** @ORM\Mapping\Entity */
+abstract class AbstractClassWithPublicMethodAndOrmMappingEntityAnnotationInInlineDocBlock
+{
+    public function method(): void
+    {
+    }
+}
diff --git a/...Success/AbstractClassWithPublicMethodAndOrmMappingEntityAnnotationInMultilineDocBlock.php b/...Success/AbstractClassWithPublicMethodAndOrmMappingEntityAnnotationInMultilineDocBlock.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\FinalInAbstractClassRule\Success;
+
+/**
+ * @ORM\Mapping\Entity
+ */
+abstract class AbstractClassWithPublicMethodAndOrmMappingEntityAnnotationInMultilineDocBlock
+{
+    public function method(): void
+    {
+    }
+}