From 8c24d5d46b656c6c4e1b15b8bb91fb561ae19f6b Mon Sep 17 00:00:00 2001 From: aestene Date: Thu, 16 Jan 2025 10:50:28 +0100 Subject: [PATCH] Refactor names in mission event handler tests --- .../EventHandlers/TestMissionEventHandler.cs | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/backend/api.test/EventHandlers/TestMissionEventHandler.cs b/backend/api.test/EventHandlers/TestMissionEventHandler.cs index 4dd402ac..d6fed515 100644 --- a/backend/api.test/EventHandlers/TestMissionEventHandler.cs +++ b/backend/api.test/EventHandlers/TestMissionEventHandler.cs @@ -347,31 +347,31 @@ public async Task QueuedMissionsAreNotAbortedWhenRobotAvailableHappensAtTheSameT plant.PlantCode ); var robot = await DatabaseUtilities.NewRobot(RobotStatus.Available, installation, null); - var missionRun1 = await DatabaseUtilities.NewMissionRun( + var missionRunOne = await DatabaseUtilities.NewMissionRun( installation.InstallationCode, robot, inspectionArea, true ); - var missionRun2 = await DatabaseUtilities.NewMissionRun( + var missionRunTwo = await DatabaseUtilities.NewMissionRun( installation.InstallationCode, robot, inspectionArea, true ); - var missionRunCreatedEventArgs = new MissionRunCreatedEventArgs(missionRun1); + var missionRunCreatedEventArgs = new MissionRunCreatedEventArgs(missionRunOne); MissionRunService.RaiseEvent( nameof(Api.Services.MissionRunService.MissionRunCreated), missionRunCreatedEventArgs ); Thread.Sleep(1000); - var missionRun1PostCreation = await MissionRunService.ReadById( - missionRun1.Id, + var missionRunOnePostCreation = await MissionRunService.ReadById( + missionRunOne.Id, readOnly: true ); - Assert.NotNull(missionRun1PostCreation); + Assert.NotNull(missionRunOnePostCreation); // Act var mqttIsarMissionEventArgs = new MqttReceivedArgs( @@ -379,7 +379,7 @@ public async Task QueuedMissionsAreNotAbortedWhenRobotAvailableHappensAtTheSameT { RobotName = robot.Name, IsarId = robot.IsarId, - MissionId = missionRun1PostCreation.IsarMissionId, + MissionId = missionRunOnePostCreation.IsarMissionId, Status = "successful", Timestamp = DateTime.UtcNow, } @@ -397,16 +397,16 @@ public async Task QueuedMissionsAreNotAbortedWhenRobotAvailableHappensAtTheSameT ); // Assert - var postTestMissionRun1 = await MissionRunService.ReadById( - missionRun1.Id, + var postTestMissionRunOne = await MissionRunService.ReadById( + missionRunOne.Id, readOnly: true ); - Assert.Equal(MissionStatus.Successful, postTestMissionRun1!.Status); - var postTestMissionRun2 = await MissionRunService.ReadById( - missionRun2.Id, + Assert.Equal(MissionStatus.Successful, postTestMissionRunOne!.Status); + var postTestMissionRunTwo = await MissionRunService.ReadById( + missionRunTwo.Id, readOnly: true ); - Assert.Equal(MissionStatus.Pending, postTestMissionRun2!.Status); + Assert.Equal(MissionStatus.Pending, postTestMissionRunTwo!.Status); } #pragma warning disable xUnit1004