Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to image carousel to allow editors to add optional CTA to each image #2610

Open
NickHaggerty1 opened this issue Oct 30, 2024 · 0 comments · May be fixed by #2768
Open

Add option to image carousel to allow editors to add optional CTA to each image #2610

NickHaggerty1 opened this issue Oct 30, 2024 · 0 comments · May be fixed by #2768
Assignees
@millianapia

Comments

@NickHaggerty1
Copy link
Collaborator

Considerations:
Follow link logic (internal or external)
Link display consistent with the Campaign grid

image carousel with link.png
@millianapia millianapia self-assigned this Nov 13, 2024
millianapia added a commit that referenced this issue Nov 19, 2024
@millianapia
🔧 Sanity CTA setup #2610
ba956f5
millianapia added a commit that referenced this issue Nov 19, 2024
@millianapia
🎨 Introduce fields and types #2610
1f4ecc3
millianapia added a commit that referenced this issue Nov 19, 2024
@millianapia
🎨 Add CTA #2610
57c1739
millianapia added a commit that referenced this issue Dec 5, 2024
@millianapia
WIP: change to gridlinkarrow #2610
29ce8be
millianapia added a commit that referenced this issue Dec 5, 2024
@millianapia
WIP: still no link #2610
e16bae9
millianapia added a commit that referenced this issue Dec 6, 2024
@millianapia
💡Working CTA #2610
102f2d7
millianapia added a commit that referenced this issue Dec 6, 2024
@millianapia
Adjust amount of actions #2610
44c4fcd
millianapia added a commit that referenced this issue Dec 6, 2024
@millianapia
♻️ Refactor gridlinkarrow variant #2610
493fbe1
millianapia added a commit that referenced this issue Dec 6, 2024
@millianapia
WIP: moved buttons #2610
dc55cb8 
still missing working autoplay, making it toggle between the modes and styling the text correctly
millianapia added a commit that referenced this issue Jan 8, 2025
@millianapia
remove hidden #2610
9c4d2f4
millianapia added a commit that referenced this issue Jan 8, 2025
@millianapia
♻️ Remove unused import #2610
a3fc3b5
millianapia added a commit that referenced this issue Jan 8, 2025
@millianapia
♻️ Remove unused import #2610
a4e3ed0
millianapia added a commit that referenced this issue Jan 22, 2025
@millianapia
✨ Text under image and CTA #2610
9652402
millianapia added a commit that referenced this issue Jan 22, 2025
@millianapia
💄 Add toggling for text under image #2610
19deafe
millianapia added a commit that referenced this issue Jan 22, 2025
@millianapia
💄 adjust padding for caption and credit #2610
5dc1bb1
millianapia added a commit that referenced this issue Jan 22, 2025
@millianapia
💄 Adjust for phonesize #2610
3a7d0b0
@millianapia millianapia linked a pull request Jan 22, 2025 that will close this issue
Add option to image carousel to allow editors to add optional CTA to each image #2610 #2768
Open
millianapia added a commit that referenced this issue Jan 23, 2025
@millianapia
💄 Moving buttons above slide #2610
d7f33ca
millianapia added a commit that referenced this issue Jan 28, 2025
@millianapia
WIP: Move captionposition logic #2610
160c62b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millianapia millianapia

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@millianapia @NickHaggerty1