Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Too high of tolerance #173

Open
ericpassmore opened this issue Jan 22, 2025 · 1 comment
Open

Test: Too high of tolerance #173

ericpassmore opened this issue Jan 22, 2025 · 1 comment

Comments

@ericpassmore
Copy link
Contributor

ericpassmore commented Jan 22, 2025

Transferred from AntelopeIO/reference-contracts#94 original author heifner

Many tests have too high of a tolerance:
https://github.com/AntelopeIO/reference-contracts/blob/cd645b54a176f0c8b5f2f5ea9b21f47b7f9bf7eb/tests/eosio.system_tests.cpp#L1013
I'm assuming the test author meant 1e-5 not 1e+5.
All the tests that use a tolerance should be inspected and fixed.

@ericpassmore
Copy link
Contributor Author

EOS System Contract Code Reference

BOOST_FIXTURE_TEST_CASE( vote_for_producer, eosio_system_tester, * boost::unit_test::tolerance(1e+5) ) try {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant