Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW2.0: convert types to geodataframes #24

Open
3 of 12 tasks
ecoon opened this issue Mar 11, 2022 · 0 comments
Open
3 of 12 tasks

WW2.0: convert types to geodataframes #24

ecoon opened this issue Mar 11, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request v2.0

Comments

@ecoon
Copy link
Collaborator

ecoon commented Mar 11, 2022

In v2, shapely is deprecating the ability to add attributes to a shape. This breaks a lot of things, because we store properties in a 'properties' dictionary as an attribute of the shape. The better way to deal with this is geopandas and the GeoDataFrame, which is a pandas DataFrame that includes a "geometry" or other column that includes shapely objects.

The goal of this work will be to modernize WW to use a few common libraries:

  1. geopandas for all shapefile storage
  2. xarray for all raster storage
  3. pynhd and friends for data downloads
  4. possibly uxarray for exo mesh writing?

Currently this work is happening on branch ecoon/geopandas_xarray

  • Update environments with new package list @ecoon , @jgomezvelez
  • All file_managers that currently return fiona objects should be refactored to return GeoDataFrames. @jgomezvelez
  • Figure out how to get common attribute names across NHD variants @jgomezvelez , @ecoon
  • All River objects will store a GeoDataFrame, and the node of the tree will refer to an index. @ecoon
  • SplitHUC::polygons() will return a GeoDataFrame; properties of the HUC will be stored internally as a GeoDataFrame. @ecoon
  • Add file managers for pynhd, other hyriver packages @jgomezvelez
  • Refactor and clean up all other utilities for working with the refactor of RiverTree and SplitHUCs @ecoon
  • Refactor and clean up hi-level API @ecoon
  • Library tests pass @ecoon
  • Refactor and test from jupyter notebooks @saubhagya-gatech
  • Make a decision around plotting
  • Release!
@ecoon ecoon added the enhancement New feature or request label Mar 11, 2022
@ecoon ecoon self-assigned this Mar 11, 2022
@ecoon ecoon changed the title convert types to geodataframes WW2.0: convert types to geodataframes Nov 1, 2024
@ecoon ecoon added the v2.0 label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.0
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants