Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate commitment creation from proof creation in sigma-protocols #110

Open
fjarri opened this issue Mar 21, 2024 · 0 comments
Open

Separate commitment creation from proof creation in sigma-protocols #110

fjarri opened this issue Mar 21, 2024 · 0 comments
Labels
code quality Making things simpler
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Mar 21, 2024

In some of the sigma-protocols (prm, sch, mod) we have a separate Commitment object. In others the commitment variables are created along with the proof itself since the challenge is non-interactive.

It makes sense to extract the commitments in all the protocols: it emphasizes the proof structure, and makes it harder to forget to hash the commitment when generating a challenge (the error that was fixed in #109). Need to see if it would introduce significant boilerplate though.

@fjarri fjarri added the code quality Making things simpler label Mar 21, 2024
@fjarri fjarri added this to the v1.0.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Making things simpler
Projects
None yet
Development

No branches or pull requests

1 participant