add more docker spin-up time for mix's laptop #440
+53
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankiebee
requested changes
Dec 18, 2024
|
to clarify what i mean https://www.npmjs.com/package/dotenv |
|
Yeah this crossed my mind. Good call |
mixmix
commented
Jan 12, 2025
| @@ -21,8 +19,6 @@ test('test the four-nodes docker script', async (t) => { | |||
| // context: all run does is checks that it runs | |||
| await run('network up', spinNetworkUp(networkType)) | |||
|
|
|||
| await sleep(process.env.GITHUB_WORKSPACE ? 30_000 * 2 : 5_000 * 2) | |||
There was a problem hiding this comment.
this is now in spinNetworkUp , I think removing this line is gonna save us 60s in CI 😆
|
Ready for re-review @frankiebee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my little laptop needs 11s to spin up the docker containers 😢
I've been hacking the
node_modulesbut it's annoying, so here we go!