Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle extra non-Enthought copyright line(s) #16

Open
corranwebster opened this issue Nov 9, 2020 · 0 comments
Open

Handle extra non-Enthought copyright line(s) #16

corranwebster opened this issue Nov 9, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@corranwebster
Copy link

corranwebster commented Nov 9, 2020

There are a number of files in ETS, particularly handling Qt support which also have copyright attributed to Riverbank Computing, for example https://github.com/enthought/pyface/blob/master/pyface/ui/qt4/action/action_item.py which starts with:

# (C) Copyright 2007 Riverbank Computing Limited
# (C) Copyright 2005-2020 Enthought, Inc., Austin, TX
# All rights reserved.
#
# This software is provided without warranty under the terms of the BSD
# license included in LICENSE.txt and may be redistributed only under
# the conditions described in the aforementioned license. The license
# is also available online at http://www.enthought.com/licenses/BSD.txt
#
# Thanks for using Enthought open source!

These are sufficiently common it would be good to just accept this variant. The simplest way to do this would be to add the line as an optional part of the regular expression, but it may make sense to make something a bit more general.

@corranwebster corranwebster added the enhancement New feature or request label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant