Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Traits observers instead of listeners #416

Open
corranwebster opened this issue Sep 25, 2020 · 1 comment
Open

Use Traits observers instead of listeners #416

corranwebster opened this issue Sep 25, 2020 · 1 comment
Labels
ETS Backlog Good issue for ETS team members to look at type: refactor

Comments

@corranwebster
Copy link
Contributor

This perhaps should wait for Enable 5.1 rather than 5.0, but we should switch to using the new Traits observer system rather than the current listener system (ie. on_trait_change).
@corranwebster corranwebster added type: refactor ETS Backlog Good issue for ETS team members to look at labels Sep 25, 2020
This was referenced Mar 1, 2021
Merged
Merged
This was referenced Mar 2, 2021
Merged
Merged
@aaronayres35
Copy link
Contributor

NOTE:
Some of the changes in enable will require a corresponding change in traitsUI. For example trying to observe a method defined on a base class in traitsUI in enable code. That handler method will need its signature changed for things to work.
ref: #663 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ETS Backlog Good issue for ETS team members to look at type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corranwebster @aaronayres35